feat: add `stats/incr/nanmax` by jalajk3004 · Pull Request #5989 · stdlib-js/stdlib

jalajk3004 · 2025-03-12T05:39:32Z

Resolves #5550

Description

What is the purpose of this pull request?

This pull request:

adds a package nanmax, which works like max in which it calculates max incrementally ignoring NaN values

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add stats/incr/nanmax #5550

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…evelop

stdlib-bot · 2025-03-12T05:41:05Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanmax	$\\color{green}137/137$ $\\color{green}+0.00\\%$	$\\color{green}8/8$ $\\color{green}+0.00\\%$	$\\color{green}2/2$ $\\color{green}+0.00\\%$	$\\color{green}137/137$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

jalajk3004 · 2025-03-12T14:58:39Z

@kgryte, Removed all the linting errors, Please review this PR once again.

kgryte · 2025-11-19T05:47:27Z

/stdlib merge

kgryte · 2025-12-27T09:46:02Z

/stdlib merge

Planeshifter · 2026-03-10T00:33:36Z

+{
+  "name": "@stdlib/stats/incr/nanmax",
+  "version": "0.0.0",
+  "description": "Compute a maximum value incrementally, while ignoring `NaN` values.",


No backticks around NaN in package.json descriptions.

Suggested change

"description": "Compute a maximum value incrementally, while ignoring `NaN` values.",

"description": "Compute a maximum value incrementally, while ignoring NaN values.",

Planeshifter · 2026-03-10T00:33:38Z

+*
+* ## Notes
+*
+* -   If provided `NaN` or a value which, when used in computations, results in `NaN`, the accumulated value is `NaN` for all future invocations.


This note is copied from incrmax and contradicts the NaN-ignoring behavior of this package.

Suggested change

* - If provided `NaN` or a value which, when used in computations, results in `NaN`, the accumulated value is `NaN` for all future invocations.

* - If provided `NaN`, the value is ignored and the accumulated value remains unchanged.

Planeshifter · 2026-03-10T00:33:42Z

+		v = randu() * 100.0;
+	}
+	max = accumulator( v );
+	console.log( '%d\t%d', v.toFixed( 4 ), ( max === null ) ? NaN : max.toFixed( 4 ) );


.toFixed() returns a string, so %d will coerce it back to a number and strip trailing zeros. Use %s instead.

Suggested change

console.log( '%d\t%d', v.toFixed( 4 ), ( max === null ) ? NaN : max.toFixed( 4 ) );

console.log( '%s\t%s', v.toFixed( 4 ), ( max === null ) ? 'null' : max.toFixed( 4 ) );

Requested changes applied in the maintainer cleanup commit: removed the incorrect NaN note in index.d.ts, dropped the package.json description backticks, and fixed the example output. Dismissing the stale review.

- Remove incorrect NaN-propagation note from index.d.ts (contradicted the NaN-ignoring behavior) - Drop backticks from package.json description and align README/repl wording - Remove inappropriate overflow note (a maximum does not accumulate/sum) - Fix examples output to use %s and guard against a null accumulated value - Remove a stray tab in a test title; add an all-NaN returns-null test - Bump copyright year to 2026

Planeshifter

Let's land it!

stdlib-bot · 2026-07-07T05:30:17Z

PR Commit Message

feat: add `stats/incr/nanmax`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5989
Closes: https://github.com/stdlib-js/stdlib/issues/5550

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

jalajk3004 and others added 5 commits March 8, 2025 15:02

edit

f3d4e01

edit

ddced1c

Merge branch 'develop' of https://github.com/jalajk3004/stdlib into d…

0ab0cf6

…evelop

Merge branch 'stdlib-js:develop' into develop

65d1ef4

added nanmax

ea5425b

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 12, 2025

jalajk3004 added 3 commits March 12, 2025 11:23

lint error

31a58a3

verify

eaca68c

check

fe12468

kgryte changed the title ~~feat: add stats/incr/nancv~~ feat: add stats/incr/nanmax Mar 12, 2025

kgryte self-requested a review March 12, 2025 06:49

jalajk3004 added 4 commits March 12, 2025 14:28

ident

3ff2128

reviewed

5303568

constructor removed

1ad1cd2

lint

f2c591b

jalajk3004 mentioned this pull request Mar 29, 2025

[RFC]: Developer dashboard for tracking ecosystem build failures stdlib-js/google-summer-of-code#120

Closed

7 tasks

kgryte added the Feature Issue or pull request for adding a new feature. label Apr 30, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 19, 2025

Merge remote-tracking branch 'upstream/develop' into nanmax

ab4fe8c

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 19, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 27, 2025

Merge remote-tracking branch 'upstream/develop' into nanmax

34622fc

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 27, 2025

Planeshifter previously requested changes Mar 10, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026

Planeshifter mentioned this pull request Jul 7, 2026

Land stats/incr PRs by jalajk3004 stdlib-js/metr-issue-tracker#1007

Closed

Planeshifter requested a review from a team July 7, 2026 04:48

stdlib-bot added the Needs Review A pull request which needs code review. label Jul 7, 2026

Planeshifter force-pushed the nanmax branch 2 times, most recently from a0ac52c to 633fac5 Compare July 7, 2026 05:02

Planeshifter force-pushed the nanmax branch from 633fac5 to 7a8ed07 Compare July 7, 2026 05:12

Planeshifter approved these changes Jul 7, 2026

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 7, 2026

stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 7, 2026

Planeshifter merged commit 9fc1615 into stdlib-js:develop Jul 7, 2026
32 checks passed

stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jul 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `stats/incr/nanmax`#5989

feat: add `stats/incr/nanmax`#5989
Planeshifter merged 15 commits into
stdlib-js:developfrom
jalajk3004:nanmax

jalajk3004 commented Mar 12, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Mar 12, 2025 •

edited

Loading

Uh oh!

jalajk3004 commented Mar 12, 2025

Uh oh!

kgryte commented Nov 19, 2025

Uh oh!

kgryte commented Dec 27, 2025

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	"description": "Compute a maximum value incrementally, while ignoring `NaN` values.",
	"description": "Compute a maximum value incrementally, while ignoring NaN values.",

	* - If provided `NaN` or a value which, when used in computations, results in `NaN`, the accumulated value is `NaN` for all future invocations.
	* - If provided `NaN`, the value is ignored and the accumulated value remains unchanged.

	console.log( '%d\t%d', v.toFixed( 4 ), ( max === null ) ? NaN : max.toFixed( 4 ) );
	console.log( '%s\t%s', v.toFixed( 4 ), ( max === null ) ? 'null' : max.toFixed( 4 ) );

Uh oh!

Uh oh!

Conversation

jalajk3004 commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

jalajk3004 commented Mar 12, 2025

Uh oh!

kgryte commented Nov 19, 2025

Uh oh!

kgryte commented Dec 27, 2025

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jul 7, 2026

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jalajk3004 commented Mar 12, 2025 •

edited

Loading

stdlib-bot commented Mar 12, 2025 •

edited

Loading